-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: UtdCause enum in reporting hooks and encryption event #3337
Conversation
aa002a6
to
ceb9fb1
Compare
ceb9fb1
to
519a4d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 83.62% 83.63%
=======================================
Files 241 242 +1
Lines 24926 24939 +13
=======================================
+ Hits 20844 20857 +13
Misses 4082 4082 ☔ View full report in Codecov by Sentry. |
519a4d1
to
b5e2eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have nothing to say about this patch; it is just great. Nice code, nice commits, nice tests, thanks!
We want to decorate messages we can't decrypt based on why we can't decrypt them. This PR detects the
membership
info provided if the server implements MSC4115 and provides that feedback to the client via theUtdCause
enum, which we expect to expand in the future.