Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: UtdCause enum in reporting hooks and encryption event #3337

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Apr 16, 2024

We want to decorate messages we can't decrypt based on why we can't decrypt them. This PR detects the membership info provided if the server implements MSC4115 and provides that feedback to the client via the UtdCause enum, which we expect to expand in the future.

@andybalaam andybalaam force-pushed the andybalaam/utd-type-info branch 6 times, most recently from aa002a6 to ceb9fb1 Compare April 23, 2024 14:00
@andybalaam andybalaam marked this pull request as ready for review April 23, 2024 14:22
@andybalaam andybalaam requested a review from a team as a code owner April 23, 2024 14:22
@andybalaam andybalaam requested review from bnjbvr and removed request for a team April 23, 2024 14:22
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.63%. Comparing base (8f5e1f3) to head (89abb75).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3337   +/-   ##
=======================================
  Coverage   83.62%   83.63%           
=======================================
  Files         241      242    +1     
  Lines       24926    24939   +13     
=======================================
+ Hits        20844    20857   +13     
  Misses       4082     4082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybalaam andybalaam requested review from Hywan and removed request for bnjbvr April 24, 2024 07:10
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to say about this patch; it is just great. Nice code, nice commits, nice tests, thanks!

@andybalaam andybalaam merged commit 4156170 into main Apr 25, 2024
35 checks passed
@andybalaam andybalaam deleted the andybalaam/utd-type-info branch April 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants