Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline: include the remote event's origin in the timeline position/end #3350

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Apr 22, 2024

And don't assume inserting to the end means it's coming from sync — as it won't be true for forward pagination anymore.

Supports #3234, extracted from #3329.

@bnjbvr bnjbvr requested a review from a team as a code owner April 22, 2024 15:33
@bnjbvr bnjbvr requested review from andybalaam and removed request for a team April 22, 2024 15:33
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 83.61%. Comparing base (d986437) to head (fa4018b).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk-ui/src/timeline/inner/state.rs 62.50% 3 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/event_handler.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   83.62%   83.61%   -0.01%     
==========================================
  Files         241      241              
  Lines       24916    24926      +10     
==========================================
+ Hits        20835    20842       +7     
- Misses       4081     4084       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

and don't assume inserting to the end means it's coming from sync — as
it won't be true for forward pagination anymore.
@bnjbvr bnjbvr force-pushed the bnjbvr/remote-event-origin branch from c4ea72a to fa4018b Compare April 23, 2024 11:31
@bnjbvr bnjbvr enabled auto-merge (rebase) April 23, 2024 11:32
@bnjbvr bnjbvr merged commit 8f5e1f3 into main Apr 23, 2024
35 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/remote-event-origin branch April 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants