FFI: Allow the creation of a matrix.to link for any room alias. #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
approved these changes
Apr 29, 2024
|
Thanks for the super quick review 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
- Coverage 83.65% 83.63% -0.02%
==========================================
Files 242 242
Lines 25012 25012
==========================================
- Hits 20923 20919 -4
- Misses 4089 4093 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the FFI currently supports creating a matrix.to room alias link directly from a
Room, there isn't a way to do so when you already have one as a string. This PR fixes that by adding a globalmatrix_to_room_alias_permalinkmethod similar to the existingmatrix_to_user_permalinkmethod. (This is only useful against an alias, as a plain room ID doesn't provide enough info to construct the URL with the necessary via parameters).