clippy: disable the box_default lint #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clippy website explains that `Box::new(Default::default())` can be shortened to `Box::default()` and that it's more readable. That's true… when you don't have a generic parameter in the mix (which may be required if rustc can't infer the type of the boxee), in which case it just looks bad, e.g. `Box::<MyType>::default()` instead of `Box::new(MyType::default())`. I do strongly prefer the latter, and propose to get rid of the lint, as a result.
poljar
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 242 242
Lines 25012 25012
=======================================
+ Hits 20923 20925 +2
+ Misses 4089 4087 -2 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clippy website explains that
Box::new(Default::default())can be shortened toBox::default()and that it's more readable. That's true… when you don't have a generic parameter in the mix (which may be required if rustc can't infer the type of the boxee), in which case it just looks bad, e.g.Box::<MyType>::default()instead ofBox::new(MyType::default()).I do strongly prefer the latter, and propose to get rid of the lint, as a result.