timeline: reset pagination status if a live back-pagination is aborted #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
approved these changes
Apr 30, 2024
| } | ||
|
|
||
| impl ResetStatusGuard { | ||
| fn new(status: SharedObservable<PaginationStatus>, target: PaginationStatus) -> Self { |
There was a problem hiding this comment.
Any reason why target is the first argument here: https://github.com/matrix-org/matrix-rust-sdk/pull/3359/files#diff-a6ab59f890b91b82d1648c9c8bbd78c6387ece6d89f8a30683fe941be504628eR147 and the second in this code?
If not, I'd recommend keeping the order consistent.
There was a problem hiding this comment.
There's no reason, so you're right, we should make it consistent. I slightly prefer state first, then target, so I'll switch the other one around. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 83.48% 83.49%
=======================================
Files 243 243
Lines 25052 25060 +8
=======================================
+ Hits 20915 20924 +9
+ Misses 4137 4136 -1 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/interrupting-backpagination-timeline
branch
from
3a10489
to
5eb10a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repetition of #3359 but at a different layer: the timeline has its own observable state for a back-pagination status, and we should also reset it when using back-pagination on a live timeline.
Instead of doing this, we should probably have the status + the pagination being handled in the event cache, using the new Paginator API, but that's a bigger change that I'm working on, and it changes many many public APIs related to the event cache, so I'm slightly postponing that and instead I propose to get this simpler fix merged.
Part of #3355.