-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event cache/timeline: reuse the Paginator
when running back-paginations
#3373
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48bc7fe - Browse repository at this point
Copy the full SHA 48bc7feView commit details -
event cache: move the
pagination_token_notifier
into the `RoomPagin……ationData` as well
Configuration menu - View commit details
-
Copy full SHA for 8862d00 - Browse repository at this point
Copy the full SHA 8862d00View commit details -
event cache: introduce a
RoomPagination
API object and move code ar……ound Only code motion. No changes in functionality.
Configuration menu - View commit details
-
Copy full SHA for 3ca4c98 - Browse repository at this point
Copy the full SHA 3ca4c98View commit details -
event cache: remove "paginate" (et al.) in
RoomPagination
method namesNo changes in functionality, just renamings.
Configuration menu - View commit details
-
Copy full SHA for 2300253 - Browse repository at this point
Copy the full SHA 2300253View commit details -
event_cache/timeline: have the event cache handle restarting a back-p…
…agination that failed under our feet When a timeline reset happens while we're back-paginating, the event cache method to run back pagination would return an success result indicating that the pagination token disappeared. After thinking about it, it's not the best API in the world; ideally, the backpagination mechanism would restart automatically. Now, this was handled in the timeline before, and the reason it was handled there was because it was possible to back-paginate and ask for a certain number of events. I've removed that feature, so that back-pagination on a live timeline matches the capabilities of a focused-timeline back-pagination: one can only ask for a given number of *events*, not timeline items. As a matter of fact, this simplifies the code a lot by removing many data structures, that were also exposed (and unused, since recent changes) in the FFI layer.
Configuration menu - View commit details
-
Copy full SHA for bbd20b0 - Browse repository at this point
Copy the full SHA bbd20b0View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2070b0 - Browse repository at this point
Copy the full SHA b2070b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf01cb1 - Browse repository at this point
Copy the full SHA cf01cb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3002389 - Browse repository at this point
Copy the full SHA 3002389View commit details