Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Notify when the identity status of a user changes #4022

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

andybalaam
Copy link
Contributor

Fixes element-hq/element-meta#2526

If you follow the stream returned from matrix_sdk::room::Room::subscribe_to_identity_status_changes you will receive an update every time someone in the room changes identity status e.g. becomes "Unpinned", meaning the UI should display a warning.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 54.70085% with 53 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (2a03de3) to head (9b023af).

Files with missing lines Patch % Lines
...tes/matrix-sdk/src/room/identity_status_changes.rs 0.00% 26 Missing ⚠️
crates/matrix-sdk/src/room/mod.rs 0.00% 19 Missing ⚠️
...x-sdk-crypto/src/identities/room_identity_state.rs 90.90% 6 Missing ⚠️
...ates/matrix-sdk/src/encryption/identities/users.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4022      +/-   ##
==========================================
- Coverage   84.23%   84.14%   -0.10%     
==========================================
  Files         266      268       +2     
  Lines       28349    28466     +117     
==========================================
+ Hits        23881    23953      +72     
- Misses       4468     4513      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisible Crypto: Rust for EX: display a warning when an *unverified* user changes identity
1 participant