MSC3381: Polls (mk II) #3381
MSC3381: Polls (mk II) #3381
Conversation
turt2live
added
kind:feature
| and naming of fields changed. The differences are: | ||
|
|
||
| * For `m.poll.start` / `org.matrix.msc3381.poll.start`: | ||
| * `m.text` throughout becomes a single string, represented as `org.matrix.msc1767.text` |
There was a problem hiding this comment.
It seems that while this field is now required, it used to be optional, which should probably be clarified.
The reason I'm pointing that out is that we had exactly that issue with Ruma regarding the current implementations of Element Android and Element iOS, that don't send the field: ruma/ruma#1589 (comment).
| * For `m.poll.end` / `org.matrix.msc3381.poll.end`: | ||
| * `m.text` has the same change as `m.poll.start`. | ||
| * `m.poll.results` is removed. | ||
| * `org.matrix.msc3381.poll.end` is added as an empty object, and is required. |
There was a problem hiding this comment.
I don't know if it should be discarded as an implementation issue, but Element Android doesn't send this field (see ruma/ruma#1589 (comment)).
I'm guessing it could be put as optional for compatibility because there are events without it that exist in the wild.
There was a problem hiding this comment.
Android would be "non-compliant" with this, but it sounds like Ruma is overly strict as well. The intention of Extensible Events is that if you know about the event type then the fallback is ignored. In other words, it's required on send, not receive.
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
|
will update the MSC text with the minor (non-blocking) changes before merge. |
@turt2live it looks like this got forgotten? |
|
It's not forgotten, but heavily delayed 😭 I'm hoping to take a look in the short term, or at least before the year ends. |
|
2ff9870 addresses the minor review feedback which came up during FCP discussions. As it didn't block FCP and the threads appear to have conclusions, I've incorporated those conclusions into the proposal text. Merging otherwise per #3381 (comment) |
turt2live
added
spec-pr-missing
|
Like #3930 (comment) , this is blocked on the wider system actually landing in the spec itself. |
Rendered
Note: the implementations below are for an earlier draft of this proposal. The latest draft does not technically have any implementations, but is not functionally different from the prior draft. That prior draft, called "v1", is available here.
Element Web Implementation:
Element iOS Implementation:
Further work:
FCP tickyboxes