-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 403 error response to federation/v1/state_ids #1926
Open
AllMightLegend
wants to merge
5
commits into
matrix-org:main
Choose a base branch
from
AllMightLegend:AllMightLegend/issue1912
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
99e0ba4
#1912 issue : Update events.yaml
AllMightLegend b7413ff
Create 1926.feature
AllMightLegend b7ae765
Rename changelogs/server_server/1926.feature to changelogs/server_ser…
AllMightLegend bc18d37
Update and rename 1926.feature to 1926.new
AllMightLegend a8224c7
Update 1926.new
AllMightLegend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
RESPONSE/server-server/edu.yaml | ||
|
||
Fixes issue #1912 by adding error response to /_matrix/federation/v1/state_ids/{roomId} | ||
|
||
CONTENT : | ||
"403": | ||
description: |- | ||
The host is not in the room or the host is banned from the room via its ACL. | ||
content: | ||
application/json: | ||
schema: | ||
$ref: ../client-server/definitions/errors/error.yaml | ||
examples: | ||
response: | ||
value: { | ||
"errcode": "M_FORBIDDEN", | ||
"error": "You do not have permission to access the state at the requested event." | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the rendered output of this PR:
This is not a useful changelog entry.
Please have a look at other changelog fragments, as well as the existing changelog, for examples of what might be appropriate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes give me a bit of time I will definitely complete it . Can you also please give me a heads up about why the output is like this and a little bit information about changelog fragments ? Appreciate your help sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked at other examples? Start there. If you still have questions, come back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay thank you sir