Merge hotfix branch into main #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular load() and setupConnection()
Track the time before processing a request
More slow request debugging
The db writes are still instant, but the notifications are now delayed by up to 1 second, in order to not swamp the pubsub channels.
- Allowing unlimited concurrency on OnE2EEData causes huge spikes in DB conns when device lists change. - Using a high, bounded amount of concurrency ensure we don't breach DB conn limits. With unit tests.
Add WorkerPool and use it for OnE2EEData
…q params Because the proxy services changes to req params preferentially to live data, if the client constantly changes the window (e.g due to spidering) then it can accidentally stop the delivery of live events to the client until the spidering process is complete. To help address this, we now process live updates _even if_ we have some data to send to the client. This is bounded in size to prevent the inverse happening: constantly seeing new live events which starves changes to req params. This should hopefully strike the right balance. With regression test.
…expired connections
…t sent by that conn
…as it's more useful this way
otherwise we only see the error message if we're using sentry.
Report a metric for the size of gappy state blocks
DMRobertson
pushed a commit
that referenced
this pull request
Jul 12, 2023
DMRobertson
suggested changes
Jul 12, 2023
DMRobertson
pushed a commit
that referenced
this pull request
Jul 12, 2023
Fix #192: ignore unseen old events
DMRobertson
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains: