Speed up startup even more #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Jul 20, 2023
DMRobertson
reviewed
Jul 20, 2023
DMRobertson
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that we are basically pulling out all joined/invited members for calculating the counts, so we might as well pull out a bit more information and use that to calculate heroes, which saves on the awful rank/partition query which took 2m45s! Byte-for-byte identical from what I can see, though I'll double check on m.org.
Also remove unused function.
With this change, startup takes 4m10s on m.org.
Without this change, startup takes 6m47s on m.org.
I have a script which JSON serialises the
StartupSnapshotto a .json file, which I then ran throughdiff, which shows zero diffs on a static DB on my laptop. It obviously changes due to live traffic when run against m.org.