-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade code main #18733
Merged
mergify
merged 57 commits into
matrixorigin:main
from
qingxinhome:UpdateUpgradeCode-main
Sep 13, 2024
Merged
Update upgrade code main #18733
mergify
merged 57 commits into
matrixorigin:main
from
qingxinhome:UpdateUpgradeCode-main
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
This reverts commit e5e8829.
…xone into UpdateUpgradeCode-main
qingxinhome
requested review from
daviszhen,
zhangxu19830126 and
LeftHandCold
as code owners
September 12, 2024 03:56
daviszhen
approved these changes
Sep 12, 2024
zhangxu19830126
approved these changes
Sep 12, 2024
matrix-meow
added
size/M
Denotes a PR that changes [100,499] lines
and removed
size/S
Denotes a PR that changes [10,99] lines
labels
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue https://github.com/matrixorigin/MO-Cloud/issues/4067
What this PR does / why we need it:
Method for reading query results during upgrade modification
Change from Unsafe to call Get String At ()
PR Type
Bug fix
Description
Unsafe
toGet String At ()
to improve safety.Changes walkthrough 📝