update delete flushThreshold

[Wenbin1002]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue # https://github.com/matrixorigin/MO-Cloud/issues/4050

What this PR does / why we need it:

update delete flushThreshold

---

PR Type

Bug fix

---

Description

• Updated the flushThreshold value in pkg/sql/colexec/deletion/types.go from 32 MB to 5 MB to address a bug.
• This change is necessary to fix issue logservice: added background job to periodically send heartbeats #4050 in the MO-Cloud repository.

---

Changes walkthrough 📝

	Relevant files
Bug fix	types.go Update `flushThreshold` value in deletion types                    pkg/sql/colexec/deletion/types.go Updated the flushThreshold value from 32 MB to 5 MB. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Performance Impact Reducing flushThreshold from 32 MB to 5 MB may impact performance. This change might lead to more frequent flushes, potentially affecting system efficiency.

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Make the flush threshold configurable through environment variables Consider making flushThreshold configurable through environment variables or a configuration file, rather than hardcoding the value. This would allow for easier adjustments without code changes. pkg/sql/colexec/deletion/types.go [38-40] var ( - flushThreshold = 5 * mpool.MB + flushThreshold = getConfigurableFlushThreshold() ) +func getConfigurableFlushThreshold() int64 { + if threshold := os.Getenv("FLUSH_THRESHOLD"); threshold != "" { + if value, err := strconv.ParseInt(threshold, 10, 64); err == nil { + return value * mpool.MB + } + } + return 5 * mpool.MB // Default value +} + Apply this suggestion Suggestion importance[1-10]: 8 Why: Making the flush threshold configurable enhances flexibility and adaptability, allowing changes without modifying the code, which is a significant improvement for maintainability and deployment.	8
Maintainability	Add a comment explaining the rationale for the chosen threshold value Add a comment explaining the rationale behind choosing 5 MB as the new threshold value. This would help future maintainers understand the decision-making process. pkg/sql/colexec/deletion/types.go [38-40] var ( + // flushThreshold is set to 5 MB to balance memory usage and performance. + // Lower values increase flush frequency, reducing memory usage but potentially impacting performance. + // Higher values decrease flush frequency, which may improve performance but increase memory usage. flushThreshold = 5 * mpool.MB ) Apply this suggestion Suggestion importance[1-10]: 7 Why: Adding a comment to explain the rationale behind the threshold value improves code readability and helps future maintainers understand the decision-making process, though it is not critical.	7