Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinker framework for gc, checkpoint, transfer etc. #18891

Closed
wants to merge 15 commits into from
Closed

sinker framework for gc, checkpoint, transfer etc. #18891

wants to merge 15 commits into from

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Sep 20, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##18892

What this PR does / why we need it:

  1. one flushing framework for all places that need to write objects.

@gouhongshen gouhongshen changed the title refactor the code of writing objects. sinker framework for writing objects Sep 20, 2024
@gouhongshen gouhongshen changed the title sinker framework for writing objects sinker framework for gc, checkpoint, transfer etc. Sep 20, 2024
@matrix-meow matrix-meow added the size/L Denotes a PR that changes [500,999] lines label Sep 20, 2024
@matrix-meow matrix-meow added size/XL Denotes a PR that changes [1000, 1999] lines and removed size/L Denotes a PR that changes [500,999] lines labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuPeng-SH XuPeng-SH Awaiting requested review from XuPeng-SH XuPeng-SH is a code owner

@LeftHandCold LeftHandCold Awaiting requested review from LeftHandCold LeftHandCold is a code owner

@triump2020 triump2020 Awaiting requested review from triump2020 triump2020 is a code owner

@zhangxu19830126 zhangxu19830126 Awaiting requested review from zhangxu19830126 zhangxu19830126 is a code owner

@reusee reusee Awaiting requested review from reusee reusee is a code owner

@aunjgr aunjgr Awaiting requested review from aunjgr aunjgr is a code owner

@daviszhen daviszhen Awaiting requested review from daviszhen daviszhen is a code owner

@qingxinhome qingxinhome Awaiting requested review from qingxinhome qingxinhome is a code owner

@aressu1985 aressu1985 Awaiting requested review from aressu1985 aressu1985 is a code owner

@heni02 heni02 Awaiting requested review from heni02 heni02 is a code owner

@sukki37 sukki37 Awaiting requested review from sukki37 sukki37 is a code owner

Assignees
No one assigned
Labels
kind/enhancement size/XL Denotes a PR that changes [1000, 1999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gouhongshen @matrix-meow @XuPeng-SH