-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: separate compiler and parser #123
refac: separate compiler and parser #123
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 52.59% 53.03% +0.43%
==========================================
Files 106 129 +23
Lines 14761 15346 +585
==========================================
+ Hits 7764 8138 +374
- Misses 6997 7208 +211 ☔ View full report in Codecov by Sentry. |
3e96f39
to
122660a
Compare
fcc3df0
to
4a43d5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanx.
4a43d5d
to
bbea151
Compare
b0fdf9f
to
b7a71db
Compare
aa4aa5a
to
cefb4ba
Compare
@hedgar2017 ready for review |
era-compiler-solidity/src/yul/parser/statement/expression/function_call/mod.rs
Outdated
Show resolved
Hide resolved
…ul-parser-into-a-separate-crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please fix the tests and we'll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to fix our release pipeline after this patch. I'll check it and get back here.
What ❔
Parameterize parser with previously LLVM-specific details (i.e. function attributes).
Why ❔
LLVM-specific logic has to be decoupled from the parser so that parser can be decoupled from the compiler and reused in other contexts.