Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the IPFS hash #128

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

hedgar2017
Copy link
Collaborator

What ❔

Adds the support for IPFS hash.

Why ❔

Requested by a partner: zkSync-Community-Hub/zksync-developers#194

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 64.67066% with 59 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (ea067e5) to head (eabea49).

Files with missing lines Patch % Lines
era-compiler-solidity/src/lib.rs 53.12% 15 Missing ⚠️
era-compiler-solidity/src/zksolc/main.rs 53.57% 13 Missing ⚠️
era-compiler-solidity/src/project/contract/mod.rs 44.44% 10 Missing ⚠️
era-compiler-solidity/src/build_evm/mod.rs 0.00% 7 Missing ⚠️
era-compiler-solidity/src/build_eravm/contract.rs 87.87% 4 Missing ⚠️
era-compiler-solidity/src/zksolc/arguments.rs 66.66% 4 Missing ⚠️
era-compiler-solidity/src/process/input_evm/mod.rs 0.00% 2 Missing ⚠️
era-compiler-solidity/src/project/mod.rs 80.00% 2 Missing ⚠️
era-compiler-solidity/src/build_evm/contract.rs 0.00% 1 Missing ⚠️
era-compiler-solidity/src/process/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   53.03%   53.09%   +0.06%     
==========================================
  Files         129      129              
  Lines       15346    15415      +69     
==========================================
+ Hits         8138     8184      +46     
- Misses       7208     7231      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hedgar2017 hedgar2017 merged commit 9a26fcd into main Sep 6, 2024
14 checks passed
@hedgar2017 hedgar2017 deleted the az-cpr-1727-implement-the-ipfs-hash-algorithm branch September 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant