Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the EraVM disassembler #136

Closed

Conversation

hedgar2017
Copy link
Collaborator

What ❔

Adds the disassembler endpoint.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 76.08696% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (b376a38) to head (349dd30).

Files with missing lines Patch % Lines
era-compiler-solidity/src/zksolc/arguments.rs 44.44% 5 Missing ⚠️
era-compiler-solidity/src/lib.rs 90.62% 3 Missing ⚠️
era-compiler-solidity/src/zksolc/main.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   52.52%   52.59%   +0.07%     
==========================================
  Files         106      106              
  Lines       14716    14761      +45     
==========================================
+ Hits         7730     7764      +34     
- Misses       6986     6997      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PavelKopyl
PavelKopyl previously approved these changes Aug 27, 2024
Copy link
Contributor

@PavelKopyl PavelKopyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayon sayon closed this Aug 29, 2024
@sayon sayon force-pushed the az-cpr-1801-add-disassembler-support-to-zksolczkvyper branch from 349dd30 to b376a38 Compare August 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants