Skip to content

Commit

Permalink
fix: Update dependency foundry compilers use of ZksolcSettings (#544)
Browse files Browse the repository at this point in the history
* Update foundry compilers for latest changes of ZksolcSettings

* Update crates/config/src/zksync.rs

Co-authored-by: Federico Rodríguez <[email protected]>

* cargo fmt

---------

Co-authored-by: Jrigada <[email protected]>
Co-authored-by: Federico Rodríguez <[email protected]>
  • Loading branch information
3 people committed Aug 29, 2024
1 parent bf71946 commit c8e23ef
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 16 deletions.
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 8 additions & 5 deletions crates/config/src/zksync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ use foundry_compilers::{
EvmVersion, Libraries,
},
solc::CliSettings,
zksolc::settings::{
BytecodeHash, Optimizer, OptimizerDetails, SettingsMetadata, ZkSolcSettings,
zksolc::{
settings::{BytecodeHash, Optimizer, OptimizerDetails, SettingsMetadata, ZkSolcSettings},
ZkSettings,
},
};

Expand Down Expand Up @@ -108,7 +109,7 @@ impl ZkSyncConfig {
jump_table_density_threshold: None,
};

ZkSolcSettings {
let zk_settings = ZkSettings {
libraries,
optimizer,
evm_version: Some(evm_version),
Expand All @@ -126,8 +127,10 @@ impl ZkSyncConfig {
per_contract: Some([OutputSelectionFlag::ABI].into()),
}),
},
cli_settings: CliSettings::default(),
}
};

// `cli_settings` get set from `Project` values when building `ZkSolcVersionedInput`
ZkSolcSettings { settings: zk_settings, cli_settings: CliSettings::default() }
}

pub fn avoid_contracts(&self) -> Option<Vec<globset::GlobMatcher>> {
Expand Down
8 changes: 3 additions & 5 deletions crates/verify/src/etherscan/flatten.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use foundry_compilers::{
solc::{SolcCompiler, SolcLanguage, SolcVersionedInput},
Compiler, CompilerInput,
},
solc::Solc,
solc::{CliSettings, Solc},
zksolc::{
input::{ZkSolcInput, ZkSolcVersionedInput},
ZkSolc, ZkSolcCompiler,
Expand Down Expand Up @@ -70,7 +70,7 @@ impl EtherscanSourceProvider for EtherscanFlattenedSource {
args: &VerifyArgs,
context: &ZkVerificationContext,
) -> Result<(String, String, CodeFormat)> {
let metadata = context.project.settings.metadata.as_ref();
let metadata = context.project.settings.settings.metadata.as_ref();
let bch = metadata.and_then(|m| m.bytecode_hash).unwrap_or_default();

eyre::ensure!(
Expand Down Expand Up @@ -190,9 +190,7 @@ Diagnostics: {diags}",
..Default::default()
},
solc_version: solc_version.clone(),
allow_paths: Default::default(),
base_path: Default::default(),
include_paths: Default::default(),
cli_settings: CliSettings::default(),
};

let solc_compiler = if compiler_version.is_zksync_solc {
Expand Down

0 comments on commit c8e23ef

Please sign in to comment.