Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More camera server functionality #2088

Merged
merged 25 commits into from
Dec 24, 2023
Merged

More camera server functionality #2088

merged 25 commits into from
Dec 24, 2023

Conversation

tbago
Copy link
Contributor

@tbago tbago commented Jun 16, 2023 •
edited by julianoes
Loading

  1. add start and stop video function, add sample code for start stop video.
  2. add start and stop video streaming function, add stream id int camera side (the camera can support multi video streaming).
  3. storage functions
  4. capture status
  5. param changed subscriptions

julianoes
julianoes reviewed Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need the proto submodule updated once it has been merged. Otherwise, I think this looks good.

@tbago
Copy link
Contributor Author

tbago commented Jun 17, 2023

Ok I will update the proto submodule, but not for now. I have more function need commit.

@tbago
Copy link
Contributor Author

tbago commented Jun 24, 2023

Add basic camera function complete.

When the proto repo is accept, will update the submodule, and complete this PR.

Other camera function will implement in new PR later.

@julianoes
Copy link
Collaborator

Thanks @tbago, let me review the proto PR again.

@tbago
Copy link
Contributor Author

tbago commented Jun 24, 2023

@julianoes Yeah, you don't need review this PR until the Mavsdk-Proto is ready.

For now may need to add more unit tests for camera server.

@julianoes julianoes changed the base branch from main to pr-consolidate-components December 17, 2023 21:38
@julianoes julianoes mentioned this pull request Dec 17, 2023
Open
@julianoes julianoes deleted the branch mavlink:main December 17, 2023 23:17
@julianoes julianoes closed this Dec 17, 2023
@julianoes julianoes reopened this Dec 17, 2023
@julianoes julianoes changed the base branch from pr-consolidate-components to main December 17, 2023 23:21
@julianoes julianoes changed the title add more camera function More camera server functionality Dec 18, 2023
tbago and others added 12 commits December 24, 2023 21:41
@tbago @julianoes
camera server : add start stop video subscribe, add start stop video …
2413639 
…example
@tbago @julianoes
camera server : add start stop video streaming, add stream id in came…
5014dfc 
…ra side
@tbago @julianoes
camera server: add subscribe camera mode and sample code
ce1bcf7
@tbago @julianoes
camera server: add storage information and capture stauts subscribe
cabd727
@tbago @julianoes
add unit on image interval and available capacity
0a2bfd4
@tbago @julianoes
storage information : add unit on read speed and write speed
3086da3
@tbago @julianoes
camera : add format storage and reset settings function
ccd3520
@tbago @julianoes
camera server: add feedback for all camera server command
2d15978
@julianoes
proto: small updates
207bffc 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: add video stream info
a11edb4 
This required the MAVLink headers to be updated.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
core: don't complain about ping
d263021 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: remove confusing duplicate logic
5eceed7 
I don't understand what this should be doing. I don't think it's right.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: remove sleeps (and some docstrings)
eebc377 
The sleeps were required because forwarding is broken in PX4. This will
hopefully be fixed with PX4 v1.14.1.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: set capture video flag
e3f23f0 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: fix capture status
14c60fc 
And keep track of the state properly.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera_server: don't forget to send mode flag
c465bc6 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
core: allow change param unsubscriptions
c3067b7 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
param_server: add param changed subscriptions
01ce134 
This enables servers to be notified when a param changes.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
examples: add missing include
2b7be2a 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera: fix a few casts
1103cb8 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
camera: remove non-sensical tests
9e70232 
We ought to have a request.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
integration_tests: fix after rebase
e07d875 
Signed-off-by: Julian Oes <[email protected]>
@julianoes
proto: update to main
38424a4 
Signed-off-by: Julian Oes <[email protected]>
@julianoes julianoes merged commit 9ebc1eb into mavlink:main Dec 24, 2023
27 checks passed
@tbago tbago deleted the add_more_camera_function branch February 22, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes left review comments

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbago @julianoes @JonasVautherin