Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing distance sensor to add orientation for multiple sensor support #2093

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

prokas-nikos
Copy link
Contributor

@prokas-nikos prokas-nikos commented Jun 26, 2023

Customized telemetry.h and telementry_impl.cpp to add the orientation parameter to telemetry.distance_sensor to add multisensor support readings on distance_sensor

Depends on mavlink/MAVSDK-Proto#321 ✔️

@JonasVautherin
Copy link
Collaborator

I think you need to fix the style in your PR (running ./tools/fix_style.sh .) and remove the unwanted files (I see a bit "output.log" file that shouldn't be here)

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's looking better!

@julianoes
Copy link
Collaborator

Looks like some namespacing issue in the build?

@prokas-nikos
Copy link
Contributor Author

Yes sorry for that. I fixed it and its building now. I checked it locally.

@julianoes
Copy link
Collaborator

@prokas-nikos sorry for the delay. I'm getting back to the merge queue here soon.

@julianoes
Copy link
Collaborator

Sorry, I dropped the ball on this. Getting it in now.

julianoes
julianoes previously approved these changes Dec 17, 2023
@julianoes julianoes changed the title Customizing distance sensor to add orientaion for multiple sensor support Customizing distance sensor to add orientation for multiple sensor support Dec 17, 2023
@julianoes julianoes merged commit d0f7294 into mavlink:main Dec 18, 2023
27 checks passed
@prokas-nikos prokas-nikos deleted the dist_sensor_orientation branch February 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants