Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fetch PX4-GPSDrivers #11785

Merged
merged 1 commit into from
Aug 25, 2024
Merged

CMake: Fetch PX4-GPSDrivers #11785

merged 1 commit into from
Aug 25, 2024

Conversation

HTRamsey
Copy link
Collaborator

Fetch PX4-GPSDrivers through CMake. Had to add an empty folder to get the include path working

@HTRamsey
Copy link
Collaborator Author

HTRamsey commented Aug 20, 2024

@julianoes is there a better way to handle the ../../definitions.h include issue?
I figure you could either run through each file and automatically replace the include line, do what I did with an empty directory to get the include path working, or copy the definitions.h into the _deps folder.

@julianoes
Copy link
Contributor

Without looking in detail, I would say the GPS repo is poorly architected and could use a bit of refactoring.

@julianoes
Copy link
Contributor

What about leaving a valid definitions.h in source in the GPS repo, and just allow PX4 (or whoever) to override it.

@HTRamsey HTRamsey merged commit 7c80109 into mavlink:master Aug 25, 2024
8 checks passed
@HTRamsey HTRamsey deleted the dev-cmake-gps branch August 25, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants