Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run MSRV check only for lib and bin targtets. #278

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

pv42
Copy link
Contributor

@pv42 pv42 commented Sep 4, 2024

See #277.
Removes tests, examples and benches (there are currently no benches) from msrv test.
Since the msrv test runs without dev dependencies they would potentially not work.

@patrickelectric
Copy link
Member

@pv42 but it's already passing, what is the point of removing it ?

@pv42
Copy link
Contributor Author

pv42 commented Sep 7, 2024

It is a reason why the CI on #276 fail.
It would also cause potential issues if anyone would like to add any dev dependencies at some point.

@patrickelectric patrickelectric merged commit 38d94ff into mavlink:master Sep 9, 2024
41 checks passed
@pv42 pv42 deleted the msrv-not-all-targets branch September 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants