Fix bug where _default_file is appended to full path with filename in… #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of directory."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stead of directory."
When using serveStatic like so:
web_server.serveStatic("/overlays/", LittleFS, "/overlays/").setDefaultFile("notfound.html");
with notfound.html in /littlefs/overlays/
And requesting a file the does not exist like so:
host/overlays/doesnotexist.bmp
Received the following errors:
[ 13319][E][vfs_api.cpp:104] open(): /littlefs/overlays/overlays/doesnotexist.bmp does not exist, no permits for creation
[ 13327][E][vfs_api.cpp:104] open(): /littlefs/overlays/overlays/doesnotexist.bmp.gz does not exist, no permits for creation
[ 13337][E][vfs_api.cpp:104] open(): /littlefs/overlays/overlays/doesnotexist.bmp/notfound.html does not exist, no permits for creation
[ 13348][E][vfs_api.cpp:104] open(): /littlefs/overlays/overlays/doesnotexist.bmp/notfound.html.gz does not exist, no permits for creation
I tested several other of my own scenarios with serveStatic() and the examples given for serveStatic() in the documentation and the _getFile() appears to work correctly now for all cases.