[REVIEW] 518 - Add pagination to "see all" pages #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pagination created with dynamic icons
|
Co-Authored-By: Jonathan Oliveira <[email protected]> Co-Authored-By: Antônio Rangel <[email protected]>
Co-Authored-By: Antônio Rangel <[email protected]> Co-Authored-By: João Pedro Chaves <[email protected]> issue memeLab#518 fix the error caused by memeLab#516
Jonathan-Oliveira
force-pushed
the
feature/518-paginate-see-all
branch
from
5fb9662
to
031b0f7
Compare
AntonioRangelC
changed the title
pablodiegoss
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Very good looking new page structure, thank you very much!
I've tested locally and I like the way it works, however I feel like we need a way to identify the current page we are looking at!
Looking at this image, you cannot guess which page I'm currently at.
A suggestion would be to set the current page as the green square we get from hovering the mouse over the page number, what do you think?
Like this:
Co-Authored-By: Jonathan Oliveira <[email protected]> Co-Authored-By: Antônio Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a pagination to the "see all" pages in the "My Collection" module
Resolves (Issues)
#518
General tasks performed
Have you confirmed the application builds locally without error? See here.