Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmark-gfm: Make sure CMARK_GFM_STATIC_DEFINE is set to 0 or 1 #1463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steffen-kiess
Copy link

Currently (with meson 1.0.1) the file build/subprojects/cmark-gfm-0.29.0.gfm.13/cmark-gfm_export.h will contain this (if default_library=static is set):

/* Is this an exclusively static build */
#if True && ! defined CMARK_GFM_STATIC_DEFINE
#  define CMARK_GFM_STATIC_DEFINE
#endif

This will cause a warning with -Wundef and will not work, because True will be evaulated as 0 by the preprocessor:

subprojects/cmark-gfm-0.29.0.gfm.13/cmark-gfm_export.h:5:5: warning: "True" is not defined, evaluates to 0 [-Wundef]
    5 | #if True && ! defined CMARK_GFM_STATIC_DEFINE

This PR makes sure that @CMARK_GFM_STATIC_DEFINE@ is always set to 0 or 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant