Add libpfm #1596
Merged
Add libpfm #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blue42u
force-pushed
the
libpfm
branch
11 times, most recently
from
61554cb
to
f4fb29a
Compare
blue42u
force-pushed
the
libpfm
branch
2 times, most recently
from
7e0f3c6
to
6f6f342
Compare
|
Why are you prefixing variable names with an underscore? It is nonstandard. |
|
Force of habit coming from Python, there private members/functions/variables are prefixed with an underscore. New version pushed to remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libpfm is unique in that building for ARM only works when also building for Linux. This causes the build to fail for MacOS arm64 in CI.
#1597 adds the logic necessary to handle this situation.EDIT: To work around the above issue without changes to the CI, this wrap is designed to only support Linux. Attempts to use it on other platforms will result in an error.