Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdwgc: provide dependency name used by many distros #1599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piperswe
Copy link

The pkg-config file for Boehm GC is typically bdw-gc.pc, so adding this will allow defaulting to the system libgc and only falling back if not present.

@eli-schwartz
Copy link
Member

The pkg-config file for Boehm GC is typically bdw-gc.pc, so adding this will allow defaulting to the system libgc and only falling back if not present.

Actually, this appears to be a bug in #487 -- I don't understand why we ever added a "gc" dependency, as it doesn't exist upstream like that. The name "bdw-gc.pc" is the canonical name, it's distributed in https://github.com/ivmai/bdwgc/blob/master/bdw-gc.pc.in

Can you remove the old name and replace it with the new one, and fix the commit message to explain that this is a bug fix, not just "something that many distros do"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants