Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the server delete panic issue and enhance error logging #16

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

Alva8756
Copy link
Contributor

@Alva8756 Alva8756 commented Feb 2, 2024

Replaced the boil.GetContextDB to sqlx.DB and tested in sandbox
Can create and delete servers successfully without panic
also checked into fleetdb pod log in the sandbox

Screenshot 2024-02-02 at 2 04 30 PM

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5a0d102) 72.72% compared to head (f055e2e) 72.69%.

Files Patch % Lines
pkg/api/v1/router_server.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   72.72%   72.69%   -0.03%     
==========================================
  Files          38       38              
  Lines        3732     3736       +4     
==========================================
+ Hits         2714     2716       +2     
- Misses        760      762       +2     
  Partials      258      258              
Flag Coverage Δ
unittests 72.69% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alva8756 Alva8756 changed the title Fix the server delete panic issue Fix the server delete panic issue and enhance error logging Feb 2, 2024
@Alva8756 Alva8756 merged commit 9f6d3e7 into main Feb 4, 2024
2 of 3 checks passed
@Alva8756 Alva8756 deleted the replace_db branch February 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants