Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on missing gin-contrib/zap replacement #32

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

DoctorVin
Copy link
Contributor

That replacement repo is gone now and blocking other folks building/developing things. Using an updated, vanilla gin-contrib/zap replaces neatly and tests clean.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (d1ebd1b) to head (ebdd5b9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   72.69%   72.72%   +0.02%     
==========================================
  Files          38       38              
  Lines        3736     3740       +4     
==========================================
+ Hits         2716     2720       +4     
  Misses        762      762              
  Partials      258      258              
Flag Coverage Δ
unittests 72.72% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DoctorVin DoctorVin merged commit 7215512 into main Mar 20, 2024
3 checks passed
@DoctorVin DoctorVin deleted the vc/update-gin-logger branch March 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants