Add Linter CI things and various shared types, methods #1
Conversation
joelrebel
commented
Sep 4, 2023
joelrebel
commented
- CI/linter setup things
- Add Condition types and Parameters.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| // ConditionStatus returns the status of the task from the KV store | ||
| // | ||
| //nolint:gocyclo // status checks are cyclomatic | ||
| func ConditionStatus(conditionID, facilityCode, kvBucket string, js nats.JetStreamContext) (TaskState, error) { |
There was a problem hiding this comment.
I don't like this function name, as it collides with the field condition.Status and will make keeping things straight more difficult.
There was a problem hiding this comment.
how about conditionStatusInKV() ?
There was a problem hiding this comment.
That or checkConditionStatus or checkTaskStatus
There was a problem hiding this comment.
since the package is called kv, it would be invoked as kv.ConditionStatus() which also conforms to https://go.dev/doc/effective_go#Getters
