Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused fields from structs #16

Merged
merged 1 commit into from
Dec 5, 2023
Merged

remove unused fields from structs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions condition/firmware_install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,6 @@ type FirmwareInstallTaskParameters struct {
// if the host is not already powered off - the install task will be failed.
RequireHostPoweredOff bool `json:"require_host_powered_off,omitempty"`

// Task priority is the task priority between 0 and 3
// where 0 is the default and 3 is the max.
//
// Tasks are picked from the `queued` state based on the priority.
//
// When there are multiple tasks with the same priority,
// the task CreatedAt attribute is considered.
Priority int `json:"priority,omitempty"`

// Firmwares is the list of firmwares to be installed.
Firmwares []Firmware `json:"firmwares,omitempty"`

Expand Down
7 changes: 1 addition & 6 deletions condition/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const (
ConditionUpdateEvent events.EventType = "update"

// ConditionStructVersion identifies the condition struct revision
ConditionStructVersion string = "1"
ConditionStructVersion string = "1.1"
)

// State is the state value of a Condition
Expand Down Expand Up @@ -136,11 +136,6 @@ type Condition struct {
// Fault is used to introduce faults into the controller when executing on a condition.
Fault *Fault `json:"fault,omitempty"`

// ResourceVersion has to be set to the value received by the
// client updating it, this it to make sure condition updates
// occur in the expected order.
ResourceVersion int64 `json:"resourceVersion"`

// UpdatedAt is when this object was last updated.
UpdatedAt time.Time `json:"updatedAt,omitempty"`

Expand Down
Loading