Moving hollow to rivets #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakeschuurmans
commented
Sep 13, 2024
•
jakeschuurmans
commented
- Move hollow to rivets
- Fix lint issues for hollow
- Remove events/controller gen mock (controller was moved to ctrl)
jakeschuurmans
force-pushed
the
FS-1733
branch
2 times, most recently
from
e0869f1
to
10fc58d
Compare
jakeschuurmans
force-pushed
the
FS-1733
branch
from
10fc58d
to
b536565
Compare
DoctorVin
previously approved these changes
Sep 13, 2024
Makefile
Outdated
| @@ -6,7 +6,7 @@ lint: | |||
|
|
|||
| ## Go test | |||
| test: lint | |||
| CGO_ENABLED=0 go test -timeout 1m -v -covermode=atomic ./... | |||
| CGO_ENABLED=0 go test -tags testtools -timeout 2m -v -covermode=atomic ./... | |||
There was a problem hiding this comment.
I guess we have long tests? Can you list them and drop a KTLO Jira for them so we don't lose track. Having long tests means people won't run them.
There was a problem hiding this comment.
mhmm, i think i might not need that anymore. I was seeing something weird and added the 2m. I can now run it without the 2m. Ill revert that.
DoctorVin
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.