Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloy v2 #26

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Alloy v2 #26

merged 7 commits into from
Sep 18, 2023

Conversation

joelrebel
Copy link
Member

@joelrebel joelrebel commented Sep 5, 2023

Implement support to run Alloy as a controller on the JS

depends on

DoctorVin
DoctorVin previously approved these changes Sep 5, 2023
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. My biggest comment/desire for change is coming up with something better than just repeated kubectl get pods to validate that the controllers were deployed properly.

Makefile Show resolved Hide resolved
scripts/nats-bootstrap/functions.sh Show resolved Hide resolved
templates/conditionorc-configmap.yaml Show resolved Hide resolved
DoctorVin
DoctorVin previously approved these changes Sep 7, 2023
@@ -26,3 +26,15 @@ Consume an event as conditionorc
```
nats consumer sub --creds=/root/nsc/nkeys/creds/KO/controllers/conditionorc.creds -s nats://nats:4222
```


list keys in statusKV buckets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably more useful to get the keys and examine individual data with kv get --raw

@joelrebel joelrebel merged commit 7ddbbb8 into main Sep 18, 2023
1 check passed
@joelrebel joelrebel deleted the alloy branch September 18, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants