Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue notifications do not show in Electron application #225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hungkoala
Copy link

Electron package.json example
"build": {
"asarUnpack": [
"./app/node_modules/node-notifier/vendor/**"
],
"extraResources": [
{
"from": "./app/node_modules/node-notifier/vendor",
"to": "app.asar.unpacked/node_modules/node-notifier/vendor"
}
]

@mikaelbr
Copy link
Owner

Hi! Thanks for submitting a PR. Could you summerize the gist of the changes? Are there any breaking changes?

@mikaelbr
Copy link
Owner

Also the changes of 736106e, are they ment to be a part of this PR?

@kevinelliott
Copy link

Ping @hungkoala

@kevinelliott
Copy link

Just a subtle nudge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants