Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] candy:core:message:chatstate triggerHandler #8

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

malakada
Copy link

@malakada malakada commented Jan 7, 2015

This probably needs a bit of thinking through/review since the entire message logic here is a little wonky.

@benlangfeld
Copy link
Member

This looks good, but there are several other events emitted by this method that need similarly updating.

@malakada
Copy link
Author

malakada commented Jan 9, 2015

I'm trying to leave the message ones until I figure out how I want to standard the message data, if that's what you mean?

@benlangfeld
Copy link
Member

Ok. Do you need input on that, or have you just not got to it yet?

@malakada
Copy link
Author

malakada commented Jan 9, 2015

I haven't gotten to it yet, but that doesn't make it mutually exclusive from wanting some input on it. ;)

#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants