Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authentication Required and Proxy Authentication Required. #107

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

ssether-usinternet
Copy link

@ssether-usinternet ssether-usinternet commented Nov 15, 2019

I found this fork of Sippy Cup that adds these two very useful features. Authentation and Proxy Auth are difficult enough in sipp that (previously) I just gave up and didn't require authentication in my test infrastructure. This addition makes the auth effortless.

Auth becomes as simple as:

require 'sippy_cup'
scenario = SippyCup::Scenario.new 'Sippy Cup',from_user: "theUsername" do |s|
  s.invite
  s.auth_required
  s.ack_answer
  s.invite headers: ["[authentication username=theUsername password=thePassword]"]
  s.wait_for_answer
  s.ack_answer
  s.sleep 20
  s.hangup
end

Proxy auth would mean using
s.proxy_auth_required
instead of
s.auth_required

This isn't my code, and I don't know why a pull request was ever created for this, but the only real potential problem as I see it is the method signature for adding a header is now an array, not a string to allow for multiple headers. If necessary to accept this merge request, it could be removed. The following commit is where it was added:
Enflick@6ae9db5

@ssether-usinternet ssether-usinternet changed the title Add authentication required and Proxy Authentication Required. Add Authentication Required and Proxy Authentication Required. Nov 15, 2019
@bklang
Copy link
Member

bklang commented Apr 14, 2020

@Karn Wanted to bring this PR to your attention. Someone else in the community opened it. Are you willing to have us merge this back into the main SippyCup repo?

@bklang
Copy link
Member

bklang commented Jun 25, 2020

@Karn Would you let us know if you are willing to have your work merged into the upstream Sippy Cup code base?

@Karn
Copy link

Karn commented Jul 4, 2020

Hey @bklang, apologies for the late reply. We can totally look at merging this back upstream, give me a few days to clean up the code and get it into a reviewing state!

@Karn Karn force-pushed the develop branch 6 times, most recently from 933d72f to 3ae18f5 Compare July 8, 2020 20:38
@Karn Karn force-pushed the develop branch 9 times, most recently from 2d0a579 to 3521f03 Compare July 10, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants