Various tweaks #14
Various tweaks #14
Conversation
sfgeorge
commented
Sep 3, 2013
sfgeorge
commented
- Little fixes to From, Contact, and Route headers
- Ensure BYEs work through proxies
| @@ -167,15 +167,16 @@ def send_digits(digits, delay = 0.250) | |||
| def send_bye(opts = {}) | |||
| msg = <<-MSG | |||
|
|
|||
| BYE sip:[service]@[remote_ip]:[remote_port] SIP/2.0 | |||
| BYE [next_url] SIP/2.0 | |||
There was a problem hiding this comment.
Is this change compatible with what was there before? The SIPp docs say:
If the "rrs" attribute in a recv command is set to "true", then the [next_url] contains the contents of the Contact header (i.e within the '<' and '>' of Contact)
If rrs is not set to true, what will [next_url] expand to?
There was a problem hiding this comment.
I'm relying on the rrs in the initial #receive_answer to be true. Without that, I believe that [next_url] would yield an empty string and break the entire exchange.
There was a problem hiding this comment.
When you say the rrs in #receive_answer, are you referring to this: https://github.com/bklang/sippy_cup/pull/15/files#L1R111 Right now it appears to be hard coded, but your other PR might make that no longer the case.
There was a problem hiding this comment.
Yep, exactly. I did happen to make changes to it in #15. But there rrs still defaults to true if not explicitly overridden. I believe that [next_url] in BYE would only break if someone explicitly set rrs to false for some reason.
|
Thanks @sfgeorge! Looks good, merging. |
