Registration issues #612
Merged
Registration issues #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update mysql-apt-config version to latest (0.8.32), the previous (0.8.16) was no longer building properly
needed to double-escape
This allows basically anything, as our users wanted emojis, and various punctuation allowed for their mottos.
Have tested against a number of XSS and malicious inputs, without any ill effects so far.... ex `<script>alert('XSS')</script>`
consolidate the avatar saving code in XSSImageCheck - Box, Team, User all had their own implementations, combined these into one `save_avatar` - new `avatar_validation` function Registration: - check avatar validation as part of form_validation function. Previously if a user provided a bad image the user/team would be created but then it would fail at avatar creation/saving....leaving them in a bad state and unable to play
|
Make sure to add yourself to |
pluto00987
added a commit
to pluto00987/RootTheBox
that referenced
this pull request
Sep 13, 2024
Box avatar upload was broken by moloch--#612 Also adjust the moloch--#617 fix by moving the validation call after the posible un-tuple
eljeffeg
pushed a commit
that referenced
this pull request
Sep 15, 2024
* Align example nginx_vhost.config with nginx.conf The vhost config had bad copy/paste for scoreboard * Fix teams starting score when banking is disabled If not using banking/money, score should start at 0 * Add default identicon avatar for teams There is already default identicon for users. Should do for teams too for some default avatar variety * Fix box edit avatar upload Box avatar upload was broken by #612 Also adjust the #617 fix by moving the validation call after the posible un-tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer:
Registration:
Avatar code consolidation: