-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Protocol to v19.2.0 and add l10n for Klar (Focus) branding #14490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes for reviewer:
srcset={ | ||
'img/firefox/browsers/mobile/index/firefox-focus-high-res.jpg': '2x' | ||
'img/firefox/mobile/firefox-focus-high-res.jpg': '2x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left the default imgs in their original location too for now, but wondering what's the best practice? Remove them and keep only in l10/en-US
? (I'd ideally symlink them, from img/l10n/en-US/*
to img/firefox/browsers/*
, but not sure how the tooling likes that…)
EDIT: removed for now, git tracks that as rename/mv, it's just not obvious in the nonl10n folder there's the last screenshot elsewhere in l10n media, but that's as designed… 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, pages that switch out images best on language should have said images in the /img/l10n
so the back-end logic switches them out, so you correctly placed them here 👍🏼
Thank you for bringing this to light!!! I suggest you convert this PR to draft for now, and we can update it when the Protocol changes come in. |
This PR is just waiting on the new Protocol version, set to publish soon: mozilla/protocol#937 |
The Protocol bump we've been waiting on is almost merged to Bedrock! Once that's done, feel free to continue on with this change :D For now, I'm going to remove the "Needs Review" label. @janbrasna go ahead and add back the label once this PR finished :) |
to support mzp-t-product-klar in wordmark classes
b766898
to
f00421f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience in waiting for the new Protocol version to get published!
I reviewed your work, and well done! This looks like it's good to go. r+ 🍉
srcset={ | ||
'img/firefox/browsers/mobile/index/firefox-focus-high-res.jpg': '2x' | ||
'img/firefox/mobile/firefox-focus-high-res.jpg': '2x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, pages that switch out images best on language should have said images in the /img/l10n
so the back-end logic switches them out, so you correctly placed them here 👍🏼
One-line summary
Enables l10n for Focus screenshot on landing page, and
locallyadds a missing class for the wordmark via Protocol update.Significant changes and points to review
Issue / Bugzilla link
Fixes #14489
Testing
(either
make build
ormake preflight
depending on how you manage deps)http://localhost:8000//de/firefox/browsers/mobile/focus/
http://localhost:8000/de/firefox/browsers/mobile/