Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish docs on release #952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janbrasna
Copy link
Contributor

Description

Pushes the tag/sha used for creating a Release to prod branch for Netlify to pick it up, building and publishing the production site.

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Testing

This aims to do no lint/tests, as that all should have been sorted out merging into main, and when the Release author selects the commit~ish for releasing/tagging, they ought to have verified everything a-ok in staging and pipeline already.

If a changeset failing to build is pushed, nothing really happens as Netlify deployment will just fail the build but still keep the previous stable deployment available so until addressed, the previous version will be served.

Pushes are ff-only otherwise rejected so are foolproof, no destructive operation can happen.

Failures as releasing older versions than already published etc. are not skipped silently, but visibly fail the run to show it didn't get published, and for what reason (diverging histories, pushing older ref, nothing in common etc.) keeping it as low level as possible. [ex]

This intentionally doesn't add a manual workflow_trigger to only really enforce tagged release sha refs not allowing arbitrary refs being pushed to prod. If a manual correction is needed, this won't interfere with any git operations undertaken, just trying to push the next released tag to the linear history of prod again. [ex]

Repository activity correctly shows when a bot updates a branch, so it can be easily distinguished if the prod push was manual or automated. [ex]

Screen Shot 2024-07-03 at 21 13 01

Push to prod on release published
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant