Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Symbol.prototype and other related Symbol and type coersion changes #1611

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Implement Symbol.prototype and other related Symbol and type coersion changes #1611

wants to merge 12 commits into from

Commits on Sep 5, 2024

  1. Sort well-known Symbol definitions

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a6c3668 View commit details
    Browse the repository at this point in the history

  2. Add asyncIterator and matchAll well-known Symbols

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    400292c View commit details
    Browse the repository at this point in the history

  3. improvements to abstract toPrototype using Symbol.toPrototype

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9664e77 View commit details
    Browse the repository at this point in the history

  4. Update compare to use toPrimitive. Improve symbol and bigint handling.

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e17cc25 View commit details
    Browse the repository at this point in the history

  5. Update toNumber, toBigInt, toString, toNumeric to use toPrimitive 

    Also improved Symbol handling in these methods. Removed checks, warnings, and return values for non-JS objects. The warnings must have been going unnoticed, because NativeArray::js_includes had been trying to convert UniqueTag.NOT_FOUND to a length for non-array-like 'this' values, so that was corrected as well.
    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    97a5d7f View commit details
    Browse the repository at this point in the history

  6. Fix a bunch of instance checks for Symbol to isSymbol() 

    And fix a spelling error.
    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    eb066d0 View commit details
    Browse the repository at this point in the history

  7. rewrite plus operator to use toPrimitive

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    04a4d53 View commit details
    Browse the repository at this point in the history

  8. toPrimitive related bug fixes

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    45bdf4c View commit details
    Browse the repository at this point in the history

  9. Update NativeDate::jsConstructor to call toPrimitive 

    ScriptRuntime.toPrimitive(Object, Class<?>) with a nullable instead of Optional type hint has also been added back to ScriptRuntime as a deprecated method.
    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8584fcc View commit details
    Browse the repository at this point in the history

  10. Implement Date.prototype[Symbol.toPrimitive] 

    Also, updated Symbol.prototype[Symbol.toPrimitive] to standardize the function name to what is in the spec.
    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e31e893 View commit details
    Browse the repository at this point in the history

  11. spotlessApply

    @tonygermano
    tonygermano committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    835cac3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. guard Symbol.toPrimitive lookup in toPrimitive AO by language version… 

    … >= ES6
    @tonygermano
    tonygermano committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    40b7494 View commit details
    Browse the repository at this point in the history