Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add item_type entries from ISO/IEC 23008-12:2022 #163

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Mar 22, 2023

No description provided.

@podborski
Copy link
Collaborator

Thanks. I think there are more missing 4CCs. For example:

  • 'mskC'
  • 'vvcC'
  • 'evcC'

@podborski podborski marked this pull request as draft March 23, 2023 00:00
@bradh
Copy link
Contributor Author

bradh commented Mar 23, 2023

Thanks. I think there are more missing 4CCs. For example:

* 'mskC'

* 'vvcC'

* 'evcC'

That is a valid criticism. I was very focused on the rgan item type, and just threw in the others because they were there (and removed 'uri ' because it flunked the CI check).

Do you know of a summary document for HEIF ed 1 to ed 2?

@bradh
Copy link
Contributor Author

bradh commented Mar 29, 2023

@podborski Did you have additional review comments on this?

@podborski
Copy link
Collaborator

@podborski Did you have additional review comments on this?

I'll review. Didn't have time to do it yet. Just briefly looked at it seems like some CMAF updates are also added. It would be good to split into 2 PRs as this one seems to address HEIF. Or, alternatively rename this PR to reflect that it also updates CMAF.

@bradh
Copy link
Contributor Author

bradh commented Mar 30, 2023

I don't think I pulled in anything from CMAF - I don't think I actually have a copy of that.

@bradh
Copy link
Contributor Author

bradh commented Apr 2, 2023

Oh, I see why it looks like it has CMAF updates. I've put a few entries that were at the end of the brands file that were out of alphabetical order into order, and those were CMAF related.

@bradh bradh marked this pull request as ready for review April 8, 2023 10:27
@podborski podborski merged commit 9b6bb36 into mp4ra:dev Aug 25, 2023
1 check passed
@bradh bradh deleted the heif_2nd_ed branch August 25, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants