Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line style options for text line elements #20854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Jan 6, 2024

Resolves: #17757

This PR introduces style settings for the 'system text line' and 'text line' elements.

Questions:

  1. Should the style pages of system text lines and text lines be combined?
  2. Should the 'hook height' option be made available in the dialog? Currently, like for pedals, it's only accessible via the properties panel.
  3. Since text lines are often used above and below the staff, should there be a hook height style setting for each?
  4. Staff text lines and other line objects (Palette items 'Line' or note anchored lines) all use the same values for line width, is a new style setting for the latter worth considering?
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@MarcSabatella
Copy link
Contributor

Is it reasonable to also add "Allow diagonal", and to make it is exposed in the Properties panel?

I know, that's kind of a separate issue - the fact that "allow diagonal" is currently missing from Properties for some lines. But if the goal here is to create a generally more consistent set of styles and properties, that one is very much missed right now.

@XiaoMigros
Copy link
Contributor Author

XiaoMigros commented Jan 6, 2024

I would like to hear @oktophonie's opinion on this- as you mentioned, the option isnt exposed for all other line elements either. Perhaps more style options should be added to different line types as well.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Jan 6, 2024

It's there for hairpins, but was somehow removed for other line types. It's definitely necessary in many cases for things like various harp notations, functional analysis, annotations for educational materials, graphic notation, etc. I actually just ran into this a couple of days ago and had it on my to-do list to open an issue next week. But since I saw this PR, I thought it worth bringing up here. I'm happy to just open the issue separately, though, as I was originally planning.

I know there was a deliberate effort to simplify the properties panel by removing seldom-used options that don't have good use cases, but diagonal lines are hardly a niche thing. I could imagine a decision to keep "allow diagonal" off the properties panel for certain specific line types where one could reasonably say there is no reason to ever make them diagonal. But for generic staff/system text lines, I think there should be no question that is is quite necessary functionality.

Workaround for now has been to enable the diagonal on a line in MU3, save the score, open the score in MU4, then add the already-customized line to the palette. So the property is definitely there and working, it just isn't exposed. But it's not really reasonable to expect people to have to do all that.

@XiaoMigros
Copy link
Contributor Author

XiaoMigros commented Jan 6, 2024

Interestingly, diagonal lines work for the textline thats just called 'line' in the lines palette, and you can add text in front of that. Perhaps its worth distinguishing between those two types as well... (so having 3 separate types of text lines: lines, staff text lines, & system text lines)

@MarcSabatella
Copy link
Contributor

Oh, that's great to know - a much better workaround! Especially since you can also add hooks etc - these really are staff text lines, they just have the allow diagonal property pre-enabled, it seems (so functionally the same as my more cumbersome workaround).

@XiaoMigros XiaoMigros force-pushed the text-line-style branch 7 times, most recently from 730e9ac to 6c52b26 Compare April 29, 2024 06:13
@XiaoMigros XiaoMigros force-pushed the text-line-style branch 6 times, most recently from 06d1421 to dc5d679 Compare July 3, 2024 10:50
@XiaoMigros XiaoMigros force-pushed the text-line-style branch 3 times, most recently from 134a47c to 6a9a0b8 Compare July 18, 2024 20:15
@XiaoMigros XiaoMigros force-pushed the text-line-style branch 2 times, most recently from 0fad056 to ea527c7 Compare August 2, 2024 21:09
@RomanPudashkin
Copy link
Contributor

@XiaoMigros please fix the failed unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staff/System Text Lines should have default style settings for the line component
3 participants