Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select tuplet when calling next-element prev-element actions #23082

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/engraving/dom/chord.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3261,6 +3261,21 @@ Ornament* Chord::findOrnament(bool forPlayback) const
return nullptr;
}

//---------------------------------
// firstGraceOrNote
//---------------------------------
Note* Chord::firstGraceOrNote()
{
GraceNotesGroup& graceNotesBefore = this->graceNotesBefore();
if (!graceNotesBefore.empty()) {
if (Chord* graceNotesBeforeFirstChord = graceNotesBefore.front()) {
return graceNotesBeforeFirstChord->notes().front();
}
}

return this->notes().back();
}

//---------------------------------
// GRACE NOTES
//---------------------------------
Expand Down
2 changes: 2 additions & 0 deletions src/engraving/dom/chord.h
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,8 @@ class Chord final : public ChordRest

String accessibleExtraInfo() const override;

Note* firstGraceOrNote();

#ifndef ENGRAVING_NO_ACCESSIBILITY
AccessibleItemPtr createAccessible() override;
#endif
Expand Down
6 changes: 6 additions & 0 deletions src/engraving/dom/chordrest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,12 @@ EngravingItem* ChordRest::prevElement()
break;
}
}

Tuplet* tuplet = this->tuplet();
if (tuplet && this == tuplet->elements().front()) {
return tuplet;
}

staff_idx_t staffId = e->staffIdx();
EngravingItem* prevItem = segment()->prevElement(staffId);
if (prevItem && prevItem->isNote()) {
Expand Down
6 changes: 4 additions & 2 deletions src/engraving/dom/navigate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,8 @@ EngravingItem* Score::nextElement()
case ElementType::NOTE:
case ElementType::REST:
case ElementType::MMREST:
case ElementType::CHORD: {
case ElementType::CHORD:
case ElementType::TUPLET: {
EngravingItem* next = e->nextElement();
if (next) {
return next;
Expand Down Expand Up @@ -865,7 +866,8 @@ EngravingItem* Score::prevElement()
case ElementType::NOTE:
case ElementType::REST:
case ElementType::MMREST:
case ElementType::CHORD: {
case ElementType::CHORD:
case ElementType::TUPLET: {
EngravingItem* prev = e->prevElement();
if (prev) {
return prev;
Expand Down
20 changes: 11 additions & 9 deletions src/engraving/dom/segment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1647,16 +1647,17 @@ EngravingItem* Segment::firstElementOfSegment(Segment* s, staff_idx_t activeStaf
{
for (auto i: s->elist()) {
if (i && i->staffIdx() == activeStaff) {
if (i->type() == ElementType::CHORD) {
Chord* chord = toChord(i);
GraceNotesGroup& graceNotesBefore = chord->graceNotesBefore();
if (!graceNotesBefore.empty()) {
if (Chord* graceNotesBeforeFirstChord = graceNotesBefore.front()) {
return graceNotesBeforeFirstChord->notes().front();
}
if (i->isDurationElement()) {
DurationElement* de = toDurationElement(i);
Tuplet* tuplet = de->tuplet();
if (tuplet && de == tuplet->elements().front()) {
return tuplet;
}
}

return toChord(i)->notes().back();
if (i->type() == ElementType::CHORD) {
Chord* chord = toChord(i);
return chord->firstGraceOrNote();
} else {
return i;
}
Expand Down Expand Up @@ -1939,7 +1940,8 @@ EngravingItem* Segment::nextElement(staff_idx_t activeStaff)
case ElementType::STAFF_STATE:
case ElementType::INSTRUMENT_CHANGE:
case ElementType::HARP_DIAGRAM:
case ElementType::STICKING: {
case ElementType::STICKING:
case ElementType::TUPLET: {
EngravingItem* next = nullptr;
if (e->explicitParent() == this) {
next = nextAnnotation(e);
Expand Down
22 changes: 22 additions & 0 deletions src/engraving/dom/tuplet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
#include "rest.h"
#include "score.h"
#include "text.h"
#include "segment.h"
#include "note.h"

#include "log.h"

Expand Down Expand Up @@ -839,4 +841,24 @@ int Tuplet::computeTupletDenominator(int numerator, Fraction totalDuration)
}
return ratio.numerator();
}

EngravingItem* Tuplet::nextElement()
{
ChordRest* firstElement = toChordRest(elements().front());
if (firstElement->type() == ElementType::CHORD) {
Chord* chord = toChord(firstElement);
return chord->firstGraceOrNote();
shoogle marked this conversation as resolved.
Show resolved Hide resolved
} else {
return toRest(firstElement);
}
return firstElement;
}

EngravingItem* Tuplet::prevElement()
{
ChordRest* firstElement = toChordRest(elements().front());
staff_idx_t staffId = firstElement->staffIdx();
EngravingItem* prevItem = firstElement->segment()->prevElement(staffId);
return prevItem;
}
} // namespace mu::engraving
4 changes: 4 additions & 0 deletions src/engraving/dom/tuplet.h
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ class Tuplet final : public DurationElement

PointF bracketL[4];
PointF bracketR[3];

EngravingItem* nextElement() override;
EngravingItem* prevElement() override;

private:

friend class DurationElement;
Expand Down