Hovering piano keyboard shows shadow note

[22justinl]

Resolves: #13273

Hovering the keys in the virtual keyboard moves the shadow note.
For tablature and drum staves the shadow note vanishes.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[cbjeukendrup]

Thanks, this looks quite good! I have a few comments, that should form a story together, if they appear in the correct order 😄

[cbjeukendrup]

Almost there! Some last cleanup remarks:

[22justinl]

Would it be fine to rename showShadowNote(const PointF& pos) to showShadowNoteForPosition() since there are now two functions to show shadow notes? Also, should I add a hoverLeaveEvent for NotationViewInputController that hides the shadow note (like with the hoverLeaveEvent in the PianoKeyboardView)

[cbjeukendrup]

Yes, both sound like good ideas!