Implement cutout shapes for clefs and dynamics in preparation of new Leland release #23768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
prepareForNewLelandCutouts
branch
from
d61051f
to
81bd584
Compare
mike-spa
force-pushed
the
prepareForNewLelandCutouts
branch
from
81bd584
to
f33c585
Compare
oktophonie
approved these changes
Aug 13, 2024
RomanPudashkin
approved these changes
Aug 13, 2024
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Aug 20, 2024
…utouts Implement cutout shapes for clefs and dynamics in preparation of new Leland release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18723
This PR prepares the logic needed to take advantage of the new shape cutouts that will come with the next release of Leland, namely for clefs and dynamics.
That means that our layout system will be able to see clefs and dynamics like this
which is extremely important in many situations, such as dynamic centering and the horizontal spacing of clef changes.
This PR does not actually update Leland, we'll wait for the new release in the Leland repo first (the screenshots are taken with an internal test version).