Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Tidy workflow files #23955

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Aug 8, 2024

Tidy the workflow files in preparation for #23067 (I'll introduce more workflows for that, but the current ones are a bit messy).

  • Remove '_build' from BUILD_MODES variable.
  • Align workflow names and filenames.

The new workflow names are sorted alphabetically to make them easier to find in the GitHub Actions list.

Old workflow names New workflow names
image image

@shoogle shoogle marked this pull request as ready for review August 8, 2024 14:35
@shoogle shoogle merged commit b07d9b1 into musescore:master Aug 8, 2024
11 checks passed
@shoogle shoogle deleted the workflow-tidy branch August 8, 2024 15:48
@@ -1,4 +1,4 @@
name: "Issue triage"
name: 'Triage: Issues'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
name: 'Triage: Issues'
name: 'Issues: Auto-triage'

Because it is more likely that we'll add more workflows about issues than about triaging things

(Oops, just too late... maybe for next PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with the "Triage" prefix because I figured we might triage PRs at some point, but we can always change to the "Issue" prefix if we end up with lots of issue-based workflows.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2024
Backport of musescore#23955

Disable translate_tx_pull_to_s3.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants