Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct style definition for harp pedal text diagram #24004

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

bakajikara
Copy link
Contributor

Fix: frame fill color style for harp text diagrams being lost after save/reload.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup added the regression nightly Works correctly in the latest released version and is broken in the nightly builds label Aug 13, 2024
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

@RomanPudashkin RomanPudashkin merged commit 8e27c32 into musescore:master Aug 14, 2024
11 checks passed
@bakajikara bakajikara deleted the harp-pedal-bg-color branch August 14, 2024 06:55
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this pull request Aug 20, 2024
Correct style definition for harp pedal text diagram
@RomanPudashkin RomanPudashkin mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression nightly Works correctly in the latest released version and is broken in the nightly builds
Projects
Development

Successfully merging this pull request may close these issues.

4 participants