Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Export: Write width and height in mm, not px #24029

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

bakajikara
Copy link
Contributor

Resolves: #22531

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 14, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 14, 2024
@cbjeukendrup cbjeukendrup requested review from oktophonie and removed request for oktophonie August 14, 2024 12:22
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#22531 FIXED

@cbjeukendrup
Copy link
Contributor

Awaiting approval from the MuseScore.com team, to be sure that this won't cause them issues

Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbjeukendrup cbjeukendrup merged commit 4ba6bf9 into musescore:master Aug 17, 2024
11 checks passed
@bakajikara bakajikara deleted the svg-size branch August 17, 2024 03:39
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong SVG page size
3 participants