Fix #23435: Large text cursor when editing dynamics text #24048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
force-pushed
the
23435-tall_text_cursor
branch
2 times, most recently
from
56c150c
to
58051b5
Compare
mathesoncalum
force-pushed
the
23435-tall_text_cursor
branch
from
58051b5
to
03191de
Compare
|
Thanks @cbjeukendrup - fixed! |
cbjeukendrup
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Looks good to me! But @igorkorsukov, please check it too :)
igorkorsukov
approved these changes
Aug 20, 2024
igorkorsukov
approved these changes
Aug 20, 2024
|
Highlighting and pressing space causes the large text cursor to come back. Deleting makes a tall text box video1775154086.mp4 |
mathesoncalum
force-pushed
the
23435-tall_text_cursor
branch
from
d545e4a
to
42136a9
Compare
mathesoncalum
force-pushed
the
23435-tall_text_cursor
branch
from
42136a9
to
cdcca9a
Compare
cbjeukendrup
approved these changes
Aug 21, 2024
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23435